Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW1 #17

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

HW1 #17

wants to merge 10 commits into from

Conversation

raykim1996
Copy link

No description provided.

@austinEng
Copy link

@raykim1996 I fixed your gh-pages deploy, so it's live now at https://github.com/raykim1996/hw01-noisy-planet

Please see the last two commits I pushed to your branch.

The deploy step will delete all files that are tracked by git (see this line). So perhaps contrary to what you might think, you DO NOT want to check in the generated bundle.js files. Instead, we want to add them to .gitignore. It's OK because the build-and-deploy.yml will still build and generate the files, and then publish the contents of the dist/ directory.

@emmaholthouser16 it looks like you experienced the same problem.

@mccannd
Copy link

mccannd commented Oct 4, 2021

Really lacking the toolbox functions, which is a major point of the assignment. Also missing noise normals implementation. There are some issues with your blinn shading model (notice the bad shadow terminator), and the moon is also unshaded. The highlight looks correct but without selective specularity or noise normals it's uncanny. I see you've put a lot of effort into differentiating the biomes, which is the saving grace here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants